Do not use integrity when request is no-cors#3099
Merged
Merged
Conversation
jeffposnick
approved these changes
Jul 19, 2022
jeffposnick
left a comment
Contributor
There was a problem hiding this comment.
Thanks for getting this changed!
| response = await handler.fetch( | ||
| new Request(request, { | ||
| integrity: integrityInRequest || integrityInManifest, | ||
| integrity: |
Contributor
There was a problem hiding this comment.
Can you add
// See https://github.com/GoogleChrome/workbox/issues/3096
so that the context is not lost?
Contributor
|
😂 🥲 😂 |
jeffposnick
approved these changes
Jul 25, 2022
|
Thanks for the fix! When do we expect this to be released? @jeffposnick |
Contributor
Author
|
It is out now: https://github.com/GoogleChrome/workbox/releases/tag/v6.5.4 |
This was referenced Sep 18, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing interaction between integrity and no-cors request in Precache Strategy
Fixes: #3096