core(audits): Add more keywords to blocklist#9986
Merged
patrickhulce merged 2 commits intoGoogleChrome:masterfrom Jan 14, 2020
Merged
core(audits): Add more keywords to blocklist#9986patrickhulce merged 2 commits intoGoogleChrome:masterfrom
patrickhulce merged 2 commits intoGoogleChrome:masterfrom
Conversation
Collaborator
|
@team if we are going to add more english phrases, we should consider moving this to our i18n pipeline. Otherwise, all the other languages will be missing these new phrases. |
paulirish
approved these changes
Nov 20, 2019
Collaborator
good idea! though I'm a little worried the translators might just make literal translations compared to what is commonplace on the web for links? then again our current setup isn't exactly super robust to check for that :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding the English keywords:
informationmore infomore informationread moresee moreAnd common Swedish terms used as link text (Google Translate links provided if you wish to confirm the meaning of the words):
härklicka härläs mermermer infomer information