Skip to content

misc: order changelog categories. add stable chrome note placeholder#9859

Merged
connorjclark merged 7 commits into
masterfrom
changelog-gen-order
Oct 26, 2019
Merged

misc: order changelog categories. add stable chrome note placeholder#9859
connorjclark merged 7 commits into
masterfrom
changelog-gen-order

Conversation

@connorjclark

Copy link
Copy Markdown
Collaborator

To test, cherry-pick this branch, checkout HEAD~10, and run yarn changelog -u.

image

see: #9857

@patrickhulce patrickhulce left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread build/changelog-generator/index.js

@brendankenny brendankenny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also +1 to @patrickhulce's comment(s) suggestion, but otherwise LGTM

Comment thread build/changelog-generator/index.js
Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>
@connorjclark connorjclark merged commit 0e3fa8b into master Oct 26, 2019
@connorjclark connorjclark deleted the changelog-gen-order branch October 26, 2019 04:05
@connorjclark connorjclark mentioned this pull request Nov 5, 2019
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants