deps: update bundlesize, add more budgets#9089
Merged
Merged
Conversation
Contributor
Author
|
If this doesn't work, we could also try out bundlewatch, which has a pretty nice details page for the bundle sizes
but doesn't have such a large community using it. https://bundlewatch.io/#/getting-started/using-bundlewatch |
patrickhulce
approved these changes
May 31, 2019
Contributor
Author
|
well, the initial api call is still 500ing...I think that's when it's trying to query the bundlesize from the parent commit (hence the We need to update anyways and I think the new status message is improved (even better when it can start querying master so we get some update on size change in that PR), so still worth landing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bundlesize has been having a bunch of issues in CI lately, and now there's a moderate security alert in one of its deps, so let's try bumping it to latest.
Unfortunately it brings in a rather heavyweight dep itself in a native brotli encoding library, but development seems to be picking back up again (siddharthkp/bundlesize#306) and that'll soon be optional if the node version has native brotli support.
Also added budgets for the other bundles as they vary quite a bit in size due to things included or not included in them.