core: remove disableDeviceEmulation flag#8289
Conversation
patrickhulce
left a comment
There was a problem hiding this comment.
Thanks @wardpeet! I think we have a few more stragglers around :)
|
🤦♂️ sorry, I fixed it. I was so focused on the javascript flag and not considering the cli flag. |
patrickhulce
left a comment
There was a problem hiding this comment.
LGTM! :)
a bummer we didn't have a chance to do any deprecation warning period though :/
|
I could add the deprecation and move this one to version 6? As I don't think it's worth it. It's a major bump but it's always nice to tell people what's going away. |
|
@wardpeet oh yeah I was thinking if anything we cherry-pick a deprecation notice onto 4.3 for a final patch release or something, agreed not worth bumping to v6 👍 |
|
oh yeah let me create a small PR for it. |
|
|
||
| // boolean values | ||
| .boolean([ | ||
| 'disable-storage-reset', 'disable-device-emulation', 'save-assets', 'list-all-audits', |
There was a problem hiding this comment.
nbd, just the flag :)
Summary
Remove disableDeviceEmulation flag and fore people on emulatedFormFactor
Related Issues/PRs
closes #7044