Skip to content

core: always run axe last#8216

Merged
brendankenny merged 2 commits into
masterfrom
axe_last
Apr 12, 2019
Merged

core: always run axe last#8216
brendankenny merged 2 commits into
masterfrom
axe_last

Conversation

@patrickhulce

Copy link
Copy Markdown
Collaborator

Summary
I broke offscreen images when I moved the image-elements gatherer down below accessibility in #7030.

This PR adds a smoketest to capture this and moves axe to the bottom with a comment.

Related Issues/PRs
broken in #7030
fixes #8211

@patrickhulce patrickhulce requested a review from paulirish as a code owner April 12, 2019 15:19

@brendankenny brendankenny left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah, good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Lazyload images

2 participants