Conversation
patrickhulce
approved these changes
Oct 25, 2018
patrickhulce
left a comment
Collaborator
There was a problem hiding this comment.
should we add a smoke test for this?
brendankenny
approved these changes
Oct 25, 2018
brendankenny
left a comment
Contributor
There was a problem hiding this comment.
LGTM2
One unfortunate thing is that the error in the smoketest ends up as an unhandled promise rejection, so the test actually still passes. I wonder if
a) unhandled promise rejections should fail smokehouse
b) we can make exceptions in the very complicated Driver._waitForFullyLoaded() execution path actually make it into the main execution chain
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
much like #6283 I've found some more of these in our logs.
performance.nowin particular seems to be overwritten in some places.oh and fixed one spot where we weren't using our own
__nativePromise.