Conversation
this also allows printed json results of the raw audits, even if no aggregations are given
| // JSON report. | ||
| if (outputMode === 'json') { | ||
| return JSON.stringify({audits: results.audits, aggregations: results.aggregations}, null, 2); | ||
| return JSON.stringify(results, null, 2); |
Contributor
Author
There was a problem hiding this comment.
json print full results, including url and initialUrl
Member
There was a problem hiding this comment.
lgtm on that.
can you confirm we have test coverage for the structure of the JSON output?
does the coverage extend to include the CLI/printer code?
Member
|
seems good. In the case of no aggregations, we were just returning nothing? |
Contributor
Author
the array of audit results were being returned directly, and the json printer was printing |
Member
|
lgtm pending the question about test coverage. |
Contributor
Author
|
sweet json output test added, fully end-to-end (of module, not cli) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Besides just being more consistent, this also allows printed
--output jsonresults of the raw audit results, even if no aggregations are given in the config.Also a good time to delete
lighthouse-core/aggregations/index.jssince that was an entire file for a map statement :)