Conversation
brendankenny
approved these changes
Apr 5, 2017
Contributor
brendankenny
left a comment
There was a problem hiding this comment.
LGTM. Feels like this should also add documentation somewhere, but we don't really do that for the other meta properties either
| @@ -19,6 +19,7 @@ interface AuditFullResult { | |||
| displayValue: string; | |||
| debugString?: string; | |||
| score: boolean|number; | |||
Contributor
There was a problem hiding this comment.
Should add it to the closure typedef too
ebidel
approved these changes
Apr 5, 2017
Contributor
|
how do you feel about |
7d27e4b to
5c36aa4
Compare
5c36aa4 to
3414327
Compare
paulirish
reviewed
Apr 5, 2017
| 'Network transfer size [costs users real dollars](https://whatdoesmysitecost.com/) ' + | ||
| 'and is [highly correlated](http://httparchive.org/interesting.php#onLoad) with long load times. ' + | ||
| 'Try to find ways to reduce the size of required files.', | ||
| scoringMode: 'numeric', |
Member
There was a problem hiding this comment.
should we use an enum? scoringMode: Audit.ScoringModes.Numeric
Contributor
|
Double LGTM |
brendankenny
reviewed
Apr 5, 2017
| * @return {{Numeric: string, Binary: string}} | ||
| */ | ||
| static get ScoringModes() { | ||
| return { |
Contributor
There was a problem hiding this comment.
should be NUMERIC and BINARY or numeric and binary IMO. also SCORING_MODES?
0737440 to
7616527
Compare
Contributor
|
Triple LGTM |
Member
|
lol u guys and the yelling. lgtm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.