core(driver): add ExecutionContext.evaluateOnObject#17050
Merged
Conversation
connorjclark
commented
Jun 3, 2026
| * @return {string} | ||
| */ | ||
| static serializeDeps(deps) { | ||
| deps = [pageFunctions.esbuildFunctionWrapperString, ...deps || []]; |
Collaborator
Author
There was a problem hiding this comment.
This was only here because direct callers of Runtime.callFunctionOn needed it to prevent minification errors from bundling / name mangling - but better to inject in _callFunctionOn. It also was already being done for _evaluateInContext (so it was sent twice for evaluate; now it's sent just once)
0a90893 to
0f23925
Compare
This adds `ExecutionContext.evaluateOnObject` to wrap the CDP `Runtime.callFunctionOn` command, providing the same ergonomics, dependency serialization, and robust error handling as `.evaluate()`. Key benefits over raw `session.sendCommand` calls: - Protects native objects from page polyfills via `_cachedNativesPreamble`. - Properly throws on browser-side execution errors via `exceptionDetails`. - Safely manages `this` context binding and parameter serialization. The `WebMCP`, `WebMcpSchemaIssues`, and `TraceElements` gatherers have been migrated to use this safer execution path. Unit tests and mock drivers are updated to reflect the new architecture.
0f23925 to
b5bec2b
Compare
paulirish
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds
ExecutionContext.evaluateOnObjectto wrap the CDPRuntime.callFunctionOncommand, providing the same ergonomics, dependency serialization, and robust error handling as.evaluate().Key benefits over raw
session.sendCommandcalls:_cachedNativesPreamble.exceptionDetails.thiscontext binding and parameter serialization.The
WebMCP,WebMcpSchemaIssues, andTraceElementsgatherers have been migrated to use this safer execution path. Unit tests and mock drivers are updated to reflect the new architecture.If a page mocked the URL constructor, it was possible these old usages of Runtime.callFunctionOn would error. Now they won't.
ref #14003