Skip to content

deps: upgrade trace_engine to 0.0.65#17046

Merged
connorjclark merged 1 commit into
mainfrom
up-te-jun2
Jun 2, 2026
Merged

deps: upgrade trace_engine to 0.0.65#17046
connorjclark merged 1 commit into
mainfrom
up-te-jun2

Conversation

@connorjclark

Copy link
Copy Markdown
Collaborator

0.0.64 to 0.0.65 changelog (all of devtools): ChromeDevTools/devtools-frontend@776967b...845cad7

git log 776967b00c...845cad7f273 -- front_end/models/trace:

Changelog (just front_end/models/trace, mostly relevant to our usage in LH)
commit 5c579f7d592622e12e9b2f8f8cce9dd36cca16b0
Author: Connor Clark <cjamcl@chromium.org>
Date:   Mon Jun 1 17:06:30 2026 -0700

    [Trace] Fix TTFB calculation for LCP insights in Lightrider
    
    Lightrider does not have standard network timing events like
    `sendEnd` for the main document request. To compute the server
    response time, it uses an internal `X-ResponseMs` header which is
    exposed as `lrServerResponseTime` by the trace processor.
    
    Previously, `calculateDocFirstByteTs` did not account for this,
    which caused the TTFB field in the LCP breakdown insight to always
    be 0 in PSI/Lightrider environments. This CL adds Lightrider
    support so that TTFB is correctly derived using this custom timing.
    
    Fixed: https://github.com/GoogleChrome/lighthouse/issues/16861
    Change-Id: I0f00b9117bdef122e7f29898d76c7c17c82b4829
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7892225
    Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
    Commit-Queue: Connor Clark <cjamcl@chromium.org>
    Auto-Submit: Connor Clark <cjamcl@chromium.org>

commit ae14bd888995772beb563e51d661aab68fdb2515
Author: Nikolay Vitkov <nvitkov@chromium.org>
Date:   Mon Jun 1 15:22:43 2026 +0200

    Remove wrapper module
    
    There is an unused module that we just reference without it having it's own file. The bundle re-export other bundles.
    This is the simples way I found to reduce some issue I was seeing with
    validation.
    
    Bug: none
    Change-Id: I7a569bc6784536a39ed633a6c82e927b1d205239
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7885453
    Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
    Reviewed-by: Simon Zünd <szuend@chromium.org>

commit 42afaa987d24befe2c8d674985bc33a1e5d58e37
Author: Nikolay Vitkov <nvitkov@chromium.org>
Date:   Mon Jun 1 14:10:52 2026 +0200

    Update chai to v6
    
    Remove the custom adapter as it's no longer compatiable and creats a
    custom one.
    Patch 1 contains the code changes
    Patch 2 will contain the changes to node_modules.
    Patch >3 fixes for the tests
    
    Bug: none
    Update-Node-Dependencies: Updates chai to v6
    Change-Id: I98350508416bb3d9a9a0fa9e881e934b4ad1db22
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7882625
    Reviewed-by: Simon Zünd <szuend@chromium.org>
    Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
    SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com>

commit eed8179e12edf5ee9b1af4d7be1904def70a3ac8
Author: Connor Clark <cjamcl@chromium.org>
Date:   Fri May 29 16:33:44 2026 -0700

    Fix TraceTree double-counting transfer size for cached requests
    
    Previously, TraceTree deliberately ignored ResourceFinish events that
    had `encodedDataLength === 0` to work around a trace bug. However, for
    actual cache hits, the transfer size *should* be 0. By ignoring it,
    TraceTree fell back to accumulating ResourceReceivedData events, which
    for cached requests incorrectly report the full uncompressed body size.
    
    This led to misreporting in the ThirdParties insight, where cache hits
    inflated the transfer size.
    
    To fix this, we now pre-scan for ResourceReceiveResponse events to build
    a mapping of which requests are cache hits. When accumulating
    ResourceReceivedData, we explicitly overwrite the transfer size to 0 if
    it is a known cache hit. We also correctly handle a ResourceFinish with
    `encodedDataLength === 0` if it is a cache hit.
    
    Fixed: 518021339
    Change-Id: I8d37aa5935df9e3dac4d70c8213c004364dd06ab
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7886420
    Auto-Submit: Connor Clark <cjamcl@chromium.org>
    Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
    Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>

commit 9a4770d2682d4efebac059e5b92e7a5c2b6a0683
Author: Connor Clark <cjamcl@chromium.org>
Date:   Thu May 28 16:30:31 2026 -0700

    [Lighthouse] make NetworkAnalyzer RTT estimator less strict
    
    Currently, Lantern throws an error if it is unable to estimate an RTT
    for any origins. This was to prevent producing inaccuracies in the
    simulation, but the tradeoff is erroring and producing no results in the
    Performance category. That's not a great tradeoff.
    
    You can reproduce this error right now in DevTools by disabling cache
    and running a mobile LH report on example.com. You may need to try a few
    time to see the issue.
    
    This CL includes these changes (1-2 are simply refactors I wanted to
    make as I was touching this code):
    
    1. Simplifies slightly by removing RTT calculation from
       estimateServerResponseTimeByOrigin, which makes
       estimateRTTByOrigin called in one place
    2. Exclude chrome-extension from RTT calculation (it wasn't harming
       anything, but it is not useful data to process)
    3. Stop throwing an error if no origins have any RTT - instead, just
       assume 0
    4. Make manual edits to lighthouse-dt-bundle.js to reflect the above
       (#3)
    
    Fixed: https://github.com/GoogleChrome/lighthouse/issues/17034
    Change-Id: Ie8018a0da40f85dc7502dcd3f0389dd0ab83658d
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7883476
    Auto-Submit: Connor Clark <cjamcl@chromium.org>
    Commit-Queue: Connor Clark <cjamcl@chromium.org>
    Reviewed-by: Paul Irish <paulirish@chromium.org>

commit 5366c1f3c565965aa83ef1fc57d001b292ead043
Author: Nikolay Vitkov <nvitkov@chromium.org>
Date:   Thu May 28 15:30:38 2026 +0200

    Clean more deps for GN
    
    This is another batch of auto fixes + small manual changes
    to make sure the builds are correct and nothing is missing/breaking.
    
    Bug: 468942591
    Change-Id: I38501da6cb9cac0b00d0e5a51388830cd8affc3f
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7879031
    Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
    Reviewed-by: Wolfgang Beyer <wolfi@chromium.org>
    Commit-Queue: Wolfgang Beyer <wolfi@chromium.org>

commit 4c6aaa5b7545b6e838b5cd4280e0087fc18cdfc6
Author: Nikolay Vitkov <nvitkov@chromium.org>
Date:   Wed May 27 11:18:34 2026 +0200

    Remove unused Deps from GN
    
    A small subset of files that were changed via the script to
    remove unused deps. Will slowly send more CLs as issue are getting
    resolved with the script.
    
    This CL remove the survey link data and effectively makes it
    dead code. This was deemed OK previously.
    
    Bug: 468942591
    Change-Id: I926600014c4a56cf5bafeb176cf63a832aa02f64
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7867827
    Reviewed-by: Nicholas Roscino <nroscino@chromium.org>
    Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
    Commit-Queue: Nicholas Roscino <nroscino@chromium.org>

commit a7f9ce9b3f6d3a79b17de55bd922531848ce38ae
Author: Alina Varkki <alinavarkki@google.com>
Date:   Wed May 20 12:17:31 2026 +0200

    Fix prototype pollution in trace FramesHandler using Map
    
    Migrate mapFrames to a built-in Map class to prevent attacker-controlled trace frame keys from interacting with or mutating Object.prototype.
    
    Bug: 513762145
    Change-Id: I35f1091349a956d2bcad99a2292c2b695302854f
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7864400
    Auto-Submit: Alina Varkki <alinavarkki@chromium.org>
    Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
    Commit-Queue: Alex Rudenko <alexrudenko@chromium.org>

commit 0a34b9acf92f6be5b9d66bdb11a7cf91daca9891
Author: Piotr Paulski <piotrpaulski@chromium.org>
Date:   Thu May 14 15:13:45 2026 +0000

    Roll browser-protocol and CfT
    
    This roll requires a manual review. See http://go/reviewed-rolls for guidance.
    
    Rolling CfT pin together with browser-protocol files: https://chromium.googlesource.com/chromium/src/+log/d9144d2d049a439c7e2baf5c78e117dc881fb013..d0a32f561fad28f0f7a0c13be0c4c0c9b4246cf7
    In case of failures or errors, reach out to someone from config/owner/COMMON_OWNERS.
    
    Roll created at https://cr-buildbucket.appspot.com/build/8681828663928628177
    
    R=chrome-devtools-waterfall-gardener-emea-oncall@google.com
    
    Bug: none
    Change-Id: I80b4ac039e439f5c1f35ae90486784c73b067894
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7848055
    Owners-Override: Piotr Paulski <piotrpaulski@chromium.org>
    Reviewed-by: Nicholas Roscino <nroscino@chromium.org>
    Commit-Queue: Piotr Paulski <piotrpaulski@chromium.org>

commit b68f2cc5a65b17fc0f9b10ffa59e3c8cac1caa5f
Author: Nikolay Vitkov <nvitkov@chromium.org>
Date:   Fri May 8 10:50:38 2026 +0200

    Update GN files to include missing deps
    
    This CL uses the automation tool to add the missing dependencies to
    the list there possible so that we can split the CLs in muliple onses.
    With separation of concerns - adding deps, removing deps,
    adding tool, integrating the tool in CQ.
    
    Bug: none
    Change-Id: Ie6c789800c612e8e5c3795518f37e1402b96d4ac
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7830717
    Reviewed-by: Alex Rudenko <alexrudenko@chromium.org>
    Commit-Queue: Nikolay Vitkov <nvitkov@chromium.org>
    Auto-Submit: Nikolay Vitkov <nvitkov@chromium.org>
    SLSA-Policy-Verified: SLSA Policy Verification Service <devtools-gerritcodereview-exitgate@google.com>

commit 60ff0a017ffe6f576759d83268632ef443a643cb
Author: Alina Varkki <alinavarkki@google.com>
Date:   Mon May 4 17:18:46 2026 +0200

    Performance Panel: Add more descriptive empty states for insights
    
    AI Assistance widgets only contain a part of the whole widget and it's not visible if the insight passed or failed. These description make it more obvious and don't leave the wisdget empty.
    
    Bug: 503296282
    Change-Id: I6e4360afc02e64e01767c1998cd8501cc0147418
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7806182
    Auto-Submit: Alina Varkki <alinavarkki@chromium.org>
    Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
    Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>

commit 7f8ad87b4ca7150ce5bc23447a117b1785aba78e
Author: Alina Varkki <alinavarkki@google.com>
Date:   Tue Apr 28 14:13:37 2026 +0200

    Add isInsightKey function
    
    Bug: 503296282
    Change-Id: Ia8c687135d8889a2c975755deb82a57d4167a214
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7793318
    Commit-Queue: Alina Varkki <alinavarkki@chromium.org>
    Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>
    Reviewed-by: Jack Franklin <jacktfranklin@chromium.org>
    Auto-Submit: Alina Varkki <alinavarkki@chromium.org>

commit ec38dc481d04fb0428eabf94d68b683e71f99993
Author: Jack Franklin <jacktfranklin@chromium.org>
Date:   Tue Apr 21 17:25:05 2026 +0100

    Trace: deal with missing `metadata` field
    
    Our types assume that a `metadata` key is present, because there is when
    we export our traces. But other tools omit the key if there is no data,
    so that can break DevTools. This CL updates the incoming file types to
    represent that; we default to an empty object if it is not given, which
    aligns with the types in the trace engine.
    
    Fixed: 499166358
    Change-Id: I8042862fe229ff8a2e9a520992f4f4334fadc70d
    Reviewed-on: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/7781974
    Reviewed-by: Paul Irish <paulirish@chromium.org>
    Commit-Queue: Jack Franklin <jacktfranklin@chromium.org>

Fixes: #16861 #13613 #16833 #17034

@connorjclark connorjclark requested a review from a team as a code owner June 2, 2026 22:19
@connorjclark connorjclark requested review from paulirish and removed request for a team June 2, 2026 22:19
@connorjclark connorjclark merged commit 25c7b88 into main Jun 2, 2026
35 checks passed
@connorjclark connorjclark deleted the up-te-jun2 branch June 2, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Time to First Byte reported as 0 ms in LCP Breakdown

1 participant