Skip to content

new_audit(webmcp-form-coverage): add audit for missing webmcp tool annotations#16964

Merged
lusayaa merged 7 commits into
mainfrom
webmcp-form-coverage-2
Apr 16, 2026
Merged

new_audit(webmcp-form-coverage): add audit for missing webmcp tool annotations#16964
lusayaa merged 7 commits into
mainfrom
webmcp-form-coverage-2

Conversation

@lusayaa

@lusayaa lusayaa commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator

Informative audit that lists which forms are missing webmcp annotations.

8NJkjuNgegE2Lyn 77ea8EtcrCEkVmr

@lusayaa lusayaa requested a review from a team as a code owner April 13, 2026 21:02
@lusayaa lusayaa requested review from paulirish and removed request for a team April 13, 2026 21:02

@paulirish paulirish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

% comment

Comment thread core/audits/webmcp-form-coverage.js Outdated

const UIStrings = {
/** Title of a Lighthouse audit that lists forms found in the page for WebMCP coverage. "WebMCP" stands for "Web Model Context Protocol" and should not be translated. */
title: 'Forms without declarative WebMCP tools',

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh this is the failureTitle (i think!)

you're also gonna need a title.

see https://github.com/GoogleChrome/lighthouse/blob/72ac057f7afbce720e11e249b89ad9c0bb635205/docs/new-audits.md#naming

this may apply to your other new audit too.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're both informational, so no failure titles. Though the fact that it makes you think this is a failure title makes me think maybe this is a bad title or this really should be a warning :)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updated the title and description. decision is to not make it a warning because not having webmcp in every form could just be a choice.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They're both informational, so no failure titles.

ohhhhhhh right.
okay yeah good call! all good.

@lusayaa lusayaa merged commit 25262cf into main Apr 16, 2026
31 checks passed
@lusayaa lusayaa deleted the webmcp-form-coverage-2 branch April 16, 2026 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants