core(config): add accessibility audits to agentic-browsing-config#16963
Conversation
c25ae3e to
69c2733
Compare
69c2733 to
011abe1
Compare
lusayaa
left a comment
There was a problem hiding this comment.
if you could add a screenshot of what it looks like that would be great!
011abe1 to
e2b50e5
Compare
e2b50e5 to
fa894b9
Compare
fa894b9 to
8c8a461
Compare
8c8a461 to
f676940
Compare
f676940 to
83349fa
Compare
paulirish
left a comment
There was a problem hiding this comment.
🤔 There's another approach here that could make sense. A "aggregate" a11y tree audit.
You could create a singular "Accessibility tree is well-structured" audit.
and it could just aggregate results from all these axe rules.
Like.. roughly this idea:
axeRuleIds.map(id => AxeAudit.audit(artifacts, ruleId)).flat()and then figure out how to adapt the result table to have them all there together..
Anyway.. I leave this to you to consider.. Because right now this category is gonna have like 35 audits and 30 of them are accessibility..
and so in this this other world.. the category has like 6 audits.
I think this is up to yall and michael. i'm chill either way.. so.. LGTM but you could decide to merge and change later or any alternative. :)
I actually really like this idea. this way we don't flood the category with a bunch of audits that are already part of the a11y audit :) I imagine we'll get a lot of feedback on these dominating the category. I say let's merge this and think of how to present the data in the report. maybe a list of failing and passing audits that reference the a11y category? or maybe a table of the audits with the details and the failing elements? though that may get super cluttered. |
The new Baseline Compatibility audit introduces a UI string. This updates the allowed collisions array in to prevent CI assertion failures.
83349fa to
83fcf12
Compare
83fcf12 to
cf15a6a
Compare
Uh oh!
There was an error while loading. Please reload this page.