Skip to content

new_audit(webmcp-registered-tools): add audit to list registered webmcp tools#16959

Merged
lusayaa merged 3 commits into
mainfrom
webmcp-registered-tools
Apr 15, 2026
Merged

new_audit(webmcp-registered-tools): add audit to list registered webmcp tools#16959
lusayaa merged 3 commits into
mainfrom
webmcp-registered-tools

Conversation

@lusayaa

@lusayaa lusayaa commented Apr 9, 2026

Copy link
Copy Markdown
Collaborator

add webmcp audit to custom agentic category.

off by default for now.

note there is an issue with the CDP domain right now, where it's not showing the schema for newly registered declarative tools while WebMCP domain is enabled.

registered_tools_declarative registered_tool_imperative

@lusayaa lusayaa requested a review from a team as a code owner April 9, 2026 16:58
@lusayaa lusayaa requested review from connorjclark and paulirish and removed request for a team April 9, 2026 16:58

@paulirish paulirish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gatherer looks good!
audit feels cramped but i got some ideas.

Comment thread core/audits/webmcp-registered-tools.js Outdated
Comment thread core/audits/webmcp-registered-tools.js Outdated
Comment thread core/audits/webmcp-registered-tools.js Outdated
Comment thread core/audits/webmcp-registered-tools.js
Comment thread core/audits/webmcp-registered-tools.js Outdated
async getArtifact(context) {
const session = context.driver.defaultSession;

// Remove duplicates based on name, keeping the latest occurrence.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you witness this happening in the wild already?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No! Just being cautious. If there is multiple registrations happening for the same name, we just keep the latest.

Comment thread core/gather/gatherers/webmcp-tools.js
* @param {{tools: WebMCPTool[]}} event
*/
onToolsAdded(event) {
// Note there is a bug right now in WebMCP.enable CDP where on newly registered tools

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I tried computing the schema at registration time instead of the hard coded {} and that still didn't give me anything. Ultimately I think the children are not done processing by the time the CDP event fires. Talked to WebMCP CDP team about it and they're taking a look.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lusayaa

lusayaa commented Apr 13, 2026

Copy link
Copy Markdown
Collaborator Author

Latest report UI:
6faeK45iEyBZwVx

@lusayaa lusayaa merged commit 984294e into main Apr 15, 2026
31 checks passed
@lusayaa lusayaa deleted the webmcp-registered-tools branch April 15, 2026 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants