Skip to content

deps: upgrade deps#16943

Merged
lusayaa merged 8 commits into
mainfrom
upgrade-deps-apr-2026
Apr 3, 2026
Merged

deps: upgrade deps#16943
lusayaa merged 8 commits into
mainfrom
upgrade-deps-apr-2026

Conversation

@lusayaa

@lusayaa lusayaa commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator
-    "axe-core": "^4.11.0",
-    "chrome-devtools-frontend": "1.0.1526630",
-    "devtools-protocol": "0.0.1527314",
-    "puppeteer-core": "^24.23.0",
-    "puppeteer-core/**/devtools-protocol": "0.0.1527314"
-    "puppeteer": "^24.23.0",
-    "puppeteer/**/devtools-protocol": "0.0.1527314",
-    "third-party-web": "^0.27.0",
-    "tldts-icann": "^7.0.17",

+    "axe-core": "^4.11.2",
+    "chrome-devtools-frontend": "1.0.1608453",
+    "devtools-protocol": "0.0.1608973",
+    "puppeteer-core": "^24.40.0",
+    "puppeteer-core/**/devtools-protocol": "0.0.1608973"
+    "puppeteer": "^24.40.0",
+    "puppeteer/**/devtools-protocol": "0.0.1608973",
+    "third-party-web": "^0.29.0",
+    "tldts-icann": "^7.0.27",

@lusayaa lusayaa marked this pull request as ready for review April 2, 2026 23:05
@lusayaa lusayaa requested a review from a team as a code owner April 2, 2026 23:05
@lusayaa lusayaa requested review from connorjclark and paulirish and removed request for a team April 2, 2026 23:05

@paulirish paulirish left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice


const networkError = getNetworkError(mainRecord, context);
const interstitialError = getInterstitialError(mainRecord, networkRecords);
// @ts-expect-error - finalRecord may be a Lantern request, which is compatible enough

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sgtm

Comment thread core/lib/network-request.js Outdated
@connorjclark

connorjclark commented Apr 2, 2026

Copy link
Copy Markdown
Collaborator

when you run core/scripts/upgrade-deps.sh it should log what changed - can you please include that in the description for reference?

edit: ah I guess it doesn't log if a test failed. anyhow it was prob this:

-    "axe-core": "^4.11.0",
-    "chrome-devtools-frontend": "1.0.1526630",
-    "devtools-protocol": "0.0.1527314",
-    "puppeteer-core": "^24.23.0",
-    "puppeteer-core/**/devtools-protocol": "0.0.1527314"
-    "puppeteer": "^24.23.0",
-    "puppeteer/**/devtools-protocol": "0.0.1527314",
-    "third-party-web": "^0.27.0",
-    "tldts-icann": "^7.0.17",

+    "axe-core": "^4.11.2",
+    "chrome-devtools-frontend": "1.0.1608453",
+    "devtools-protocol": "0.0.1608973",
+    "puppeteer-core": "^24.40.0",
+    "puppeteer-core/**/devtools-protocol": "0.0.1608973"
+    "puppeteer": "^24.40.0",
+    "puppeteer/**/devtools-protocol": "0.0.1608973",
+    "third-party-web": "^0.29.0",
+    "tldts-icann": "^7.0.27",

Comment thread core/computed/document-urls.js Outdated
@lusayaa

lusayaa commented Apr 3, 2026

Copy link
Copy Markdown
Collaborator Author

yarn test-lantern results:
lantern-result.txt

@lusayaa lusayaa merged commit 607ff1a into main Apr 3, 2026
31 checks passed
@lusayaa lusayaa deleted the upgrade-deps-apr-2026 branch April 3, 2026 00:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants