Skip to content

tests(smokehouse): fix baseline config to use onlyAudits#16931

Merged
connorjclark merged 1 commit into
mainfrom
lr-baseline
Mar 26, 2026
Merged

tests(smokehouse): fix baseline config to use onlyAudits#16931
connorjclark merged 1 commit into
mainfrom
lr-baseline

Conversation

@paulirish

Copy link
Copy Markdown
Member

The Lightrider error Failed to resolve module specifier 'baseline.js' was likely caused by the test config using the audits array, which can trigger dynamic module resolution in Lighthouse's config system.

This is more consistent with other smoke tests and probably avoids the resolution error in bundled environments.

cc @TravenReese

@paulirish paulirish requested a review from a team as a code owner March 25, 2026 23:53
@paulirish paulirish requested review from connorjclark and removed request for a team March 25, 2026 23:53
@paulirish paulirish enabled auto-merge (squash) March 25, 2026 23:53
@connorjclark connorjclark disabled auto-merge March 26, 2026 19:26
@connorjclark connorjclark merged commit 8c673f8 into main Mar 26, 2026
28 of 31 checks passed
@connorjclark connorjclark deleted the lr-baseline branch March 26, 2026 19:26
@connorjclark

Copy link
Copy Markdown
Collaborator

fwiw we learned this likely wasn't necessary to fix our roll issues, but w/e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants