Skip to content

tests: fix CI. execContext count, i18n ICU breakage, loud jsdom parse output#16898

Merged
paulirish merged 7 commits into
mainfrom
fix/pptr-context-test
Mar 5, 2026
Merged

tests: fix CI. execContext count, i18n ICU breakage, loud jsdom parse output#16898
paulirish merged 7 commits into
mainfrom
fix/pptr-context-test

Conversation

@paulirish

@paulirish paulirish commented Mar 5, 2026

Copy link
Copy Markdown
Member

fixing up CI. breakages and messy test logs.

  • Fix api-test-pptr.js failure: Recent Chromium (ToT) started spawning many more isolated execution contexts (utility worlds, etc.), which broke the "exactly 2" unique ID assertion. We now filter for only "default" contexts.
  • Fix i18n-formatter-test.js failure: Node 24+ changed duration formatting (e.g. German "1 Std." -> "1h Std."). Expectations are now more relaxed to accommodate environmental differences in Intl output.
  • Silence JSDOM noise: Silenced the massive Error: Could not parse CSS stylesheet logs by using a VirtualConsole. These were non-fatal errors caused by jsdom 12 being unable to parse modern CSS (like @container and cqi units).

@paulirish paulirish requested a review from a team as a code owner March 5, 2026 00:47
@paulirish paulirish requested review from connorjclark and removed request for a team March 5, 2026 00:48
@paulirish paulirish enabled auto-merge (squash) March 5, 2026 00:50
@paulirish paulirish changed the title tests: filter for default execution contexts in api-test-pptr tests: fix CI. api-test execContext count, i18n ICU de-de breakage, loud jsdom parse output Mar 5, 2026
@paulirish paulirish changed the title tests: fix CI. api-test execContext count, i18n ICU de-de breakage, loud jsdom parse output tests: fix CI. execContext count, i18n ICU breakage, loud jsdom parse output Mar 5, 2026
@paulirish paulirish disabled auto-merge March 5, 2026 01:44
@paulirish paulirish merged commit 20b3d94 into main Mar 5, 2026
31 checks passed
@paulirish paulirish deleted the fix/pptr-context-test branch March 5, 2026 01:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant