tests(smoke): smoke tests for the mcp bundle#16883
Merged
Merged
Conversation
dd244ac to
161ff59
Compare
OrKoN
commented
Feb 24, 2026
| 'oopif-scripts', | ||
| ], | ||
| 'devtools-mcp': [ | ||
| // Disabled because performance tracing related audits are not supported. |
Contributor
Author
There was a problem hiding this comment.
@paulirish @connorjclark do you think these exclusions make sense or did we shim too many audits?
Member
There was a problem hiding this comment.
yeah its okay.
a few ones stick out
- dbw - mostly not perf but i do see it asserts on dom-size-insight.. which is perf
- errors-iframe-expired-ssl shouldnt be perf but it relies on the trace.
but... this ends up being a list of all perf/trace dependent smoketest ids which.. yeah. seems fair.
thx for working this out. i hope it was scripted somewhat so you didnt have to determine this list entirely manually!
paulirish
approved these changes
Feb 27, 2026
| 'oopif-scripts', | ||
| ], | ||
| 'devtools-mcp': [ | ||
| // Disabled because performance tracing related audits are not supported. |
Member
There was a problem hiding this comment.
yeah its okay.
a few ones stick out
- dbw - mostly not perf but i do see it asserts on dom-size-insight.. which is perf
- errors-iframe-expired-ssl shouldnt be perf but it relies on the trace.
but... this ends up being a list of all perf/trace dependent smoketest ids which.. yeah. seems fair.
thx for working this out. i hope it was scripted somewhat so you didnt have to determine this list entirely manually!
Member
|
great work! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.