misc(build): create a bundle for devtools-mcp#16858
Conversation
7197456 to
a2552bf
Compare
a2552bf to
ca9ed7a
Compare
ca9ed7a to
5282f84
Compare
5282f84 to
fe32474
Compare
cleaner shimming. and a test for functionality
05bcfa9 to
ac07e98
Compare
| /** | ||
| * @license | ||
| * Copyright 2018 Google LLC | ||
| * Copyright 2026 Google LLC |
There was a problem hiding this comment.
thanks for catching these. :)
|
@connorjclark @paulirish I do not seem to find this in the release on npm, do I need to do anything extra to have it included into the npm package? I also saw that there are some reports include into the distribution such as latest-run-oom, are these intended? https://www.npmjs.com/package/lighthouse?activeTab=code |
|
These reports do not seem to present in v12 https://www.npmjs.com/package/lighthouse/v/12.8.2 |
|
We only publish a few things from the (from .npmignore) I suggest manually creating this bundle and copying (vendoring) it into the mcp repo. You could write a few lines of bash to automate the sync.
The latest npm publish was borked, I pinged @paulirish about it. |
|
That makes sense. I currently vendor the bundle and CodeQL reports the following security issues https://github.com/ChromeDevTools/chrome-devtools-mcp/pull/831/checks?check_run_id=63222750490 and some look like thez might be actionable. I think http-link-header library might not be escaping quotes correctly, csp_evaluator might not be handling wildcards correctly, data: and vbscript: schemes might not be handled in one place, and some misdiagnosed prototype pollution? Do you know if all of these are safe to ignore in the context of Lighthouse use case? |
yup. i messed it up! sorry. fixed in v13.0.3 which just went out. |
Not sure about this one. My intuition is that it's fine. https://www.npmjs.com/package/http-link-header says it follows the RFC. Sadly the gh repo is down now, so we can't look at the test suite. But even if
safe to ignore because CSP only allows a single wildcard in addition to
yeah. this is ignorable. this is for link-text audit lighthouse/core/audits/seo/link-text.js Lines 171 to 175 in cfef2a7 the recommendation is wrong. given what we're doing there.
eh. this is in lighthouse's I don't really see an attack for how you pollute your own config. But.. shrug. |
Adds a bundle to use in Chrome DevTools MCP that includes non-performance categories (because the MCP server already does performance). The bundle includes also report generation in json and HTML. It should only include the EN locale for the report.
The bundle is not minified with legal comments inline to simplify code review when vendoring the code.