core: match scripts to network requests using frameId#16774
Merged
Conversation
Collaborator
|
don't have context for this - @paulirish still want? |
connorjclark
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a reporting issue in byte-efficiency audits (such as "Remove unused JavaScript") where cached duplicate script requests were reported with full network transfer sizes.
Impact
When a script is loaded in the main frame (network transfer) and subsequently in an iframe (cache hit), Lighthouse reported both instances with the transfer size of the first network load. This inflated the estimated network savings. With this change, cached duplicate loads are correctly mapped to their cache-hit network requests (transfer size of 0), preventing inflated savings.
aka we wont report wasted bytes on cached reqs
Technical Details
getRequestForScriptto match network records using both URL andframeId(extracted fromscript.executionContextAuxData.frameId). Falls back to URL-only matching ifframeIdis not present or unmatched.Fixes b/446165500.