Conversation
This comment was marked as outdated.
This comment was marked as outdated.
connorjclark
approved these changes
Sep 6, 2023
6 tasks
adamraine
commented
Sep 6, 2023
| 'snippet': '<span role="button" tabindex="0" id="target-size-2">', | ||
| // Exact target size can vary depending on the device. | ||
| 'explanation': /^Fix any of the following:\n {2}Target has insufficient size \([0-9.]+px by [0-9.]+px, should be at least 24px by 24px\)\n {2}Target has insufficient offset from its closest neighbor \([0-9.]+px should be at least 24px\)$/, | ||
| 'explanation': /^Fix any of the following:\n {2}Target has insufficient size \([0-9.]+px by [0-9.]+px, should be at least 24px by 24px\)\n {2}Target has insufficient space to its closest neighbors. Safe clickable space has a diameter of \{\$data\.closestOffset\}px instead of at least 24px\)$/, |
Contributor
Author
There was a problem hiding this comment.
I'm pretty sure there are typos here: dequelabs/axe-core#4148
| // id: 'color-contrast', | ||
| // }, | ||
|
|
||
| expect(axeResults.violations.find(v => v.id === 'duplicate-id')).toMatchObject({ |
Contributor
Author
There was a problem hiding this comment.
duplicate-id check has been deprecated, and will likely be removed in a future axe release: dequelabs/axe-core#3892
I don't think we need to enable it to keep this check since we aren't going to "fix" this ever.
axe-core to 4.8.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #15002
https://github.com/dequelabs/axe-core/releases/tag/v4.8.0
Several important changes:
duplicate-id-ariasurfaces it's failures inincompleteinstead ofviolations, so we need to make this audit informative.duplicate-idhas been deprecated and disabled by default. We don't have a Lighthouse audit for this but we did use it to check against our own report.target-sizechanged it's failure criteria so our smoke test captures an additional targetMajor rule inclusions / deprecations are deferred to #15440
cc @jazyan