Skip to content

tests: assert to assert/strict#14412

Merged
connorjclark merged 3 commits into
mainfrom
assert-strict
Oct 7, 2022
Merged

tests: assert to assert/strict#14412
connorjclark merged 3 commits into
mainfrom
assert-strict

Conversation

@connorjclark

Copy link
Copy Markdown
Collaborator

First commit is mechanical, no behavioral changes at all.

Second commit changes a few assert to assert/strict, that's the one to look at closely.

Closes #13883

@connorjclark connorjclark requested a review from a team as a code owner September 30, 2022 16:55
@connorjclark connorjclark requested review from adamraine and removed request for a team September 30, 2022 16:55
@connorjclark

connorjclark commented Sep 30, 2022

Copy link
Copy Markdown
Collaborator Author

Cannot find package 'assert' imported from /Users/cjamcl/src/lighthouse/build/plugins/inline-fs.js

Ah, Node 14 doesn't support assert/strict :(

But in Oct. (2022-10-18) we "can" drop Node 14... #14345

@connorjclark connorjclark merged commit b61e8c3 into main Oct 7, 2022
@connorjclark connorjclark deleted the assert-strict branch October 7, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use 'assert/strict'

3 participants