Skip to content

test(ci): add node 18 to test matrix#14015

Closed
brendankenny wants to merge 5 commits into
masterfrom
ci-18
Closed

test(ci): add node 18 to test matrix#14015
brendankenny wants to merge 5 commits into
masterfrom
ci-18

Conversation

@brendankenny

Copy link
Copy Markdown
Contributor

#13874 was dropped because of test failures. Trying again now that a couple of Node 18 minor releases are out.

The failures also might have been from c8, which should be fixed now (see c8 v7.11.1, bcoe/c8#401 (comment)).

@brendankenny brendankenny requested a review from a team as a code owner May 17, 2022 17:31
@brendankenny brendankenny requested review from connorjclark and removed request for a team May 17, 2022 17:31
Comment thread yarn.lock
resolved "https://registry.yarnpkg.com/@jridgewell/resolve-uri/-/resolve-uri-3.0.7.tgz#30cd49820a962aff48c8fffc5cd760151fca61fe"
integrity sha512-8cXDaBBHOr2pQ7j77Y6Vp5VDT2sIqWyWQ56TjEq4ih/a4iST3dItRe8Q9fp0rrIl9DoKhWQtUQz/YpOxLkXbNA==

"@jridgewell/sourcemap-codec@^1.4.10":

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder what's going on here https://github.com/jridgewell/sourcemap-codec

@brendankenny

Copy link
Copy Markdown
Contributor Author

Issues with buffers in Node 18 deep in sd-validation -> jsonld -> http-client -> ky-universal -> node-fetch, so that's cool :)

@connorjclark

Copy link
Copy Markdown
Collaborator

give up yet? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants