Skip to content

tests(ci): sample flow result check#13728

Merged
adamraine merged 20 commits into
masterfrom
flow-result-ci
Mar 17, 2022
Merged

tests(ci): sample flow result check#13728
adamraine merged 20 commits into
masterfrom
flow-result-ci

Conversation

@adamraine

Copy link
Copy Markdown
Contributor

Closes #13364

@adamraine adamraine requested a review from a team as a code owner March 8, 2022 18:40
@adamraine adamraine requested review from connorjclark and removed request for a team March 8, 2022 18:40
@adamraine adamraine changed the title core(user-flow): save/load flow artifacts json tests(ci): sample flow result check Mar 8, 2022
Comment thread package.json Outdated
"update:sample-json": "yarn i18n:collect-strings && node ./lighthouse-cli -A=./lighthouse-core/test/results/artifacts --config-path=./lighthouse-core/test/results/sample-config.js --output=json --output-path=./lighthouse-core/test/results/sample_v2.json && node lighthouse-core/scripts/cleanup-LHR-for-diff.js ./lighthouse-core/test/results/sample_v2.json --only-remove-timing",
<<<<<<< flow-result-ci -- Incoming Change
"update:flow-sample-json": "yarn i18n:collect-strings && node ./lighthouse-core/scripts/update-flow-fixtures.js",
=======

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yo

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

And that's the last time I try to resolve merge conflicts in Github

Comment thread lighthouse-core/scripts/assert-baseline-flow-result-unchanged.sh
Comment thread lighthouse-core/scripts/assert-baseline-flow-result-unchanged.sh Outdated
@adamraine adamraine merged commit 61a9ca8 into master Mar 17, 2022
@adamraine adamraine deleted the flow-result-ci branch March 17, 2022 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Gather/Audit Mode in User Flows

3 participants