tests: timing smoke test#13614
Conversation
|
Is this test adding something of use beyond what sample_v2.json or the CDT layout tests provide? I only ask, because those methods are updatable automatically, while this smoke test would need to be manually changed |
It verifies that |
connorjclark
left a comment
There was a problem hiding this comment.
one change requested, +1 otherwise
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
| </head> | ||
| <body> | ||
| <h1>Just a simple page</h1> |
There was a problem hiding this comment.
| }); | ||
|
|
||
| // Calling log.timeEnd here will retroactively update artifacts.Timing. | ||
| // Must end time here so this timing entry can be stored on saved artifacts. |
There was a problem hiding this comment.
The smoke found its first problem 🎉 . This retroactive behavior doesn't happen in DevTools.
Should be the last addition to #13569
Creates a new
_includessmoke test helper to check for a subset of an array.