core(fr): user triggered navigations#13496
Merged
Merged
Conversation
| session.setNextProtocolTimeout(Infinity); | ||
| waitForPageNavigateCmd = session.sendCommand('Page.navigate', {url: requestor}); | ||
| } else { | ||
| waitForPageNavigateCmd = requestor(); |
Collaborator
There was a problem hiding this comment.
It could be useful to make a new status logging step here, and keep the original for this method the same.
Contributor
Author
There was a problem hiding this comment.
We will have to replace the URL in the original log message with something for user controlled navigations. I think that would make a log statement here redundant.
adamraine
commented
Dec 15, 2021
Contributor
Author
|
I'm gonna start working on test cases, but this is ready for review otherwise. |
connorjclark
reviewed
Feb 9, 2022
…hthouse into fr-navigation-requestor
connorjclark
approved these changes
Feb 9, 2022
connorjclark
left a comment
Collaborator
There was a problem hiding this comment.
just add some docs about best practices for requestor function and LGTM!
paulirish
requested changes
Feb 10, 2022
Contributor
Author
|
Welcome to the future 😎 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Doc
Interested in any feedback on the callback implementation.
Some details not mentioned in design doc:
requestedUrlin a lot of places because we don't have prior knowledge of the URL with a callback function.Related
#13375
#11313