report: convert to ES modules#12702
Merged
Merged
Conversation
17 tasks
connorjclark
commented
Jun 25, 2021
| @@ -0,0 +1,16 @@ | |||
| /** | |||
Collaborator
Author
There was a problem hiding this comment.
this file should be temporary... once viewer is es modules this just goes away.
patrickhulce
left a comment
Collaborator
There was a problem hiding this comment.
WDYT about breaking this up a smidge further? it seems like the build process pieces could be in place even without the esm conversion and separate quite cleanly without much effort?
I might be misestimating the level of effort required for that, so quick gut check first :)
Collaborator
Author
|
CDT CL is fully passing its tests now. Once this PR merges we can land that and the PSI CL. The CDT integration test is presently failing with this PR, which is expected. It will be passing again when the CDT CL lands. Then I'll re-enable it as a required check. |
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ref #12689, #12623
report/rendererandreport/test/rendererto ES modulespackage.json{type: 'module'}to a couple folders, to be removed when root package.json is esmreport-generator.jsnow readsstandalone.jsfrom disk, which is generated byyarn build-report. This file is not checked into source control, but will be published.report/renderer/util.jstolighthouse-core/util-commonjs.js. Remove when ☂️ Convert to ES modules #12689 is donewindow. Remove when viewer is converted to ES modules. Same for treemapCDT CL: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2939422
PSI CL: cl/377963333