core(modern-images): update to include AVIF estimates#12682
Conversation
| description: 'Image formats like JPEG 2000, JPEG XR, and WebP often provide better ' + | ||
| description: 'Image formats like WebP and AVIF often provide better ' + | ||
| 'compression than PNG or JPEG, which means faster downloads and less data consumption. ' + | ||
| '[Learn more](https://web.dev/uses-webp-images/).', |
There was a problem hiding this comment.
docs updates here: GoogleChrome/web.dev#5696
brendankenny
left a comment
There was a problem hiding this comment.
LGTM!
-
closes #12295
do we still want to move webp to
uses-optimized-imagesat some point or are we dropping that idea and we're good to close that issue? -
how do you feel about updating
modern-image-formatsentry inbyte-efficiency/expectations.jsto include some real level of detail? :) It's pretty light right now and I'm just realizing we don't appear to have any smoke tests for theimage-elements->modern-image-formats/uses-optimized-imagespipeline beyond basically that they ran without error.
I'm comfortable dropping that idea. Adding webp encoding to one's pipeline is an order of magnitude different (and more on par with AVIF) than trimming some fat on existing JPEGs. Our 4-part rating system of score, impact, difficulty, actionability would be helpful right about now :)
Yeah SG, though IIRC we avoided detail there because of the unreliable cross-platform differences of the encoding. That was probably before our |
Summary
Updates the modern image formats audit to use AVIF file size estimates according to the plan outlined in #12295 (comment). I initially tried out showing both the WebP and AVIF estimates in the table, but a few problems:
Instead, this PR just replaces the estimate used for the audit results with the AVIF estimate, skips an image if it's already WebP, and moves the WebP estimate to a new property
wastedWebpBytes.Related Issues/PRs
closes #12295