core: remove the redirect pass and redirects-http audit#12643
core: remove the redirect pass and redirects-http audit#12643
Conversation
|
To fix #12636 sooner, WDYT about landing a version of this PR that removes the artifact and the audit always gets marked |
Good idea. |
| const gatherer = resolveGathererToDefn(gathererJson, coreGathererList, configDir); | ||
| if (!isFRGathererDefn(gatherer)) { | ||
| throw new Error(`${gatherer.instance.name} gatherer does not support Fraggle Rock`); | ||
| throw new Error(`${gatherer.instance.name} gatherer does not have a Fraggle Rock meta obj`); |
There was a problem hiding this comment.
idk about this change specifically, but it certainly is hidden in this huge unrelated PR :)
There was a problem hiding this comment.
Yeah, I was chatting with Adam about it. the config-test item that also changed had me looking at this.
adam suggested adding a todo to adjust the error message, but instead i decided to just do it. agree it's fairly distinct from the PR.
After consideration, we don't think this audit serves much value anymore.
If one is building a PWA, it clearly needs to be on HTTPS. I mean technically they could have a functional HTTP site, but in 2021, you get pretty shamed in browser UI if you do that. On top of that, Chrome's change to default HTTPS navigation mitigates the MITM concern that's been a primary motivation.
We've spoked with the installability folks and they're chill with it.
part of #11822
_
Breaking, so it'll have to wait to land, sadly, but I wanted a PR to track it early.