Skip to content

misc(treemap): update colors on enter keypress#12496

Merged
connorjclark merged 1 commit into
masterfrom
treemap-enter-colors
May 17, 2021
Merged

misc(treemap): update colors on enter keypress#12496
connorjclark merged 1 commit into
masterfrom
treemap-enter-colors

Conversation

@connorjclark

Copy link
Copy Markdown
Collaborator

ref #11254

@connorjclark connorjclark requested a review from a team as a code owner May 17, 2021 22:34
@connorjclark connorjclark requested review from patrickhulce and removed request for a team May 17, 2021 22:34
@google-cla google-cla Bot added the cla: yes label May 17, 2021
@connorjclark connorjclark mentioned this pull request May 17, 2021
24 tasks

@patrickhulce patrickhulce left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't understand why we need it, but seems cool :)

@connorjclark

Copy link
Copy Markdown
Collaborator Author

when a node is zoomed treemap lib might make more nodes. the color is set via inline CSS outside treemap lib app. so if there are more nodes we need to recolor. there's some code just before for click that does the same thing.

@connorjclark connorjclark merged commit fe4cced into master May 17, 2021
@connorjclark connorjclark deleted the treemap-enter-colors branch May 17, 2021 23:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants