Skip to content

misc(treemap): shade background for unused bytes#12486

Merged
devtools-bot merged 12 commits into
masterfrom
treemap-unusedhue
May 18, 2021
Merged

misc(treemap): shade background for unused bytes#12486
devtools-bot merged 12 commits into
masterfrom
treemap-unusedhue

Conversation

@paulirish

@paulirish paulirish commented May 14, 2021

Copy link
Copy Markdown
Member

@google-cla google-cla Bot added the cla: yes label May 14, 2021
@connorjclark

Copy link
Copy Markdown
Collaborator

I think it's too busy... prefer this:

image

also concerned how user would know which shade is unsued vs used

also concerned that we'd have two different ways to visualizing coverage.

would like to see: only highlighed nodes (the most egregious unused nodes) getting a special treatment; and that treatment being the same thing used in the coverage table column

@adamraine

Copy link
Copy Markdown
Contributor

also concerned how user would know which shade is unsued vs used

I agree, couldn't tell which shade represents "used" at first glance.

@paulirish

Copy link
Copy Markdown
Member Author

too busy

yes. it's def busy.

i prefer this:

yeah the thing i don't like about that is the arbitrary thresholds. I think there are likely still modules of interest that are slightly below those numbers. it's hard to hit a binary threshold right so i want to make it a continuous thing.

I agree, couldn't tell which shade represents "used" at first glance.

yeah totally fair. i'm gonna try a candystripe shading to see if it helps.

@connorjclark

Copy link
Copy Markdown
Collaborator

+1 to the new changes Paul demoed in today's meeting.

@connorjclark connorjclark changed the title treemap: bicolor background for unused % misc(treemap): shade background for unused bytes May 17, 2021
@paulirish paulirish marked this pull request as ready for review May 17, 2021 23:48
@paulirish paulirish requested a review from a team as a code owner May 17, 2021 23:48
@paulirish paulirish requested review from connorjclark and removed request for a team May 17, 2021 23:48
Comment thread lighthouse-treemap/app/src/main.js Outdated
Comment thread lighthouse-treemap/app/src/main.js Outdated
outline: 2px solid black;
}

.webtreemap-node::before {

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

magic? magic. ok.

Comment thread lighthouse-treemap/app/styles/treemap.css Outdated
Comment thread lighthouse-treemap/app/src/main.js Outdated
Comment thread lighthouse-treemap/app/src/main.js Outdated
@connorjclark connorjclark mentioned this pull request May 18, 2021
24 tasks
Co-authored-by: Connor Clark <cjamcl@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants