WIP: report: configure features#12327
Conversation
paulirish
left a comment
There was a problem hiding this comment.
if this file was ESM, then we could just export the setupElemScreenshots method? would that be equivalent?
|
|
||
| // Do not query the system preferences for DevTools - DevTools should only apply dark theme | ||
| // if dark is selected in the settings panel. | ||
| if (!this._dom.isDevTools() && window.matchMedia('(prefers-color-scheme: dark)').matches) { |
There was a problem hiding this comment.
is the idea that a devtools rendering config would have toggleDarkMode: false (instead of this isDevTools()) ?
There was a problem hiding this comment.
didnt consider that but ya, sure
| this._document.addEventListener('keyup', this.onKeyUp); | ||
| this._document.addEventListener('copy', this.onCopy); | ||
| if (this.featureSet.mediaQueryListeners) { | ||
| this._setupMediaQueryListeners(); |
There was a problem hiding this comment.
driveby: this fn should be renamed to applyNarrowClassSometimes or something
Ignoring the unsolved problem of us using ESM... I suppose? Although I prefer this method (shoving the entire interface into an options object) vs. making arbitrary methods "public". |
what of these features is PSI likely to end up using? |
|
I think these would be desirable:
Fireworks would be cool, but understandable to avoid :) @exterkamp wdyt? |
|
Shane agreed with the three features I listed above. |
|
also: should move |
|
the download, opening, then saving is unfortunate, but saving a gist requires having github sign in, so I'm not sure if that's ever going to work in devtools |
|
closing for #12254 |
Configuration might be useful?
no impact on the devtools integration (it overrides some printing stuff which probably shouldn't be configurable)
the PSI integration would benefit slightly