Skip to content

core(fr): add fraggle rock driver#11742

Merged
patrickhulce merged 4 commits into
masterfrom
fr_driver
Dec 2, 2020
Merged

core(fr): add fraggle rock driver#11742
patrickhulce merged 4 commits into
masterfrom
fr_driver

Conversation

@patrickhulce

Copy link
Copy Markdown
Collaborator

Summary
Builds on the work of #11623 #11633 #11685 to add the fraggle rock driver which is session aware. This is the thinnest implementation that will enable snapshot mode.

Related Issues/PRs
See #11622 and #11313 for the larger context.

@patrickhulce patrickhulce requested a review from a team as a code owner December 1, 2020 21:03
@patrickhulce patrickhulce requested review from adamraine and removed request for a team December 1, 2020 21:03
@google-cla google-cla Bot added the cla: yes label Dec 1, 2020

@connorjclark connorjclark left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread lighthouse-core/test/fraggle-rock/gather/driver-test.js
Comment thread lighthouse-core/fraggle-rock/gather/session.js Outdated
Comment thread lighthouse-core/fraggle-rock/gather/session.js Outdated
Comment thread lighthouse-core/fraggle-rock/gather/driver.js Outdated
Comment thread lighthouse-core/test/fraggle-rock/gather/session-test.js Outdated
Co-authored-by: Connor Clark <cjamcl@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants