Vercel doesn't seem to like this though, and I can't pull up the details. Did something break there with our viewer deployment?

(to answer the earlier DRY question, I'm a big fan of the rule of three, personally (master is currently at one gh-pages build file), and if Patrick wants to move to rollup he should just say so :P, but this is fine with some documentation so I don't have to read two build files and open devtools just to figure out what files are going to be included in the bundle :)

If we ever port the scorecalc to this repo, it'd use this code too.

and CPU throttling calc :)

if Patrick wants to move to rollup he should just say so

Yes, for the record again, I think it would be better if we used any modern bundler that's maintained (rollup, webpack, parcel) instead of rolling our own in multiple places. Asking @connorjclark to pickup that effort for just treemap though seemed unreasonable. In my judgement I don't view this to be a loss to readability (it actually seemed to be an improvement IMO even if we have no additional copies at all. Viewer now calls something resembling a bundler API without needing to understand the implementation of a bundler just to make sense of the script). I'm sorry if everyone else on the team views this as wasted effort, but I do appreciate it greatly and think it's a win :)

Viewer now calls something resembling a bundler API without needing to understand the implementation of a bundler just to make sense of the script

But that's the point I was making, you do still have to understand the implementation, just now it's in two different places and there are fewer comments :) Some scripts are manually added, some are pulled automatically, some are browserified, some are concatted, html just appears, etc.

Instead of automatically/magically adding sources (like adding app/src/*.js to the js), could instead do more explicit:

const app = new GhPagesApp({
    name: 'viewer',
    appDir: `${__dirname}/../lighthouse-viewer/app`,
    htmlReplacements: {
      '%%LIGHTHOUSE_TEMPLATES%%': htmlReportAssets.REPORT_TEMPLATES,
    },
    html: 'index.html', // ----------- NEW CODE ----------------
    javascripts: [
      await generatorJsPromise,
      htmlReportAssets.REPORT_JAVASCRIPT,
      fs.readFileSync(require.resolve('idb-keyval/dist/idb-keyval-min.js'), 'utf8'),
      {path: 'src/*'}, // ----------- NEW CODE ----------------
    ],
    stylesheets: [
      htmlReportAssets.REPORT_CSS,
      {path: 'styles/*'}, // ----------- NEW CODE ----------------
    ],
    assetPaths: [
      'images/**/*',
      'manifest.json',
    ],
  });

paths would use appDir as root. and be glob-able. Better?

nice, yeah, that does seem like a good change

cool, that works out a lot better.