Skip to content

v6.4.1#11513

Merged
connorjclark merged 7 commits into
masterfrom
bump_6.4.1
Oct 2, 2020
Merged

v6.4.1#11513
connorjclark merged 7 commits into
masterfrom
bump_6.4.1

Conversation

@connorjclark

Copy link
Copy Markdown
Collaborator

No description provided.

@connorjclark connorjclark requested a review from a team as a code owner October 2, 2020 19:55
@connorjclark connorjclark requested review from brendankenny and removed request for a team October 2, 2020 19:55
Comment thread changelog.md Outdated
# 6.4.1 (2020-10-02)
[Full Changelog](https://github.com/GoogleChrome/lighthouse/compare/v6.4.0...v6.4.1)

This is a minor release to fix an issue in the npm package where v6.4.0 was published as ~15GB.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~15GB

68.5MB?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, I misread the severity of this.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah sorry if I misled you @connorjclark I was trying to say this probably wasn't a showstopper since npm installing all of our deps is apparently 15GB so us increasing ~50MB isn't the end of the world, but this fix combined with the many malformed request issue in #11503 would be a nice 6.4.1 anyway if you want to continue :)

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yea might as well keep going, but I probably won't follow up with a CDT release.

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it was my fault, I read it quickly this morning then went off to do a bunch of errands, so all day this was in my head and as soon as I got to a computer I didn't check any of my assumptions

Comment thread changelog.md

## Misc

* add chromium webtests to npmignore ([#11512](https://github.com/GoogleChrome/lighthouse/pull/11512))

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really the important part for this release was the .tmp part of this PR :)

@patrickhulce patrickhulce Oct 2, 2020

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well the only things inside .tmp were chromium web test stuff. this message seems to get at the heart of it already, no?

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, fair :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants