pr#11230
Merged
Merged
Conversation
Beytoven
approved these changes
Aug 6, 2020
connorjclark
commented
Aug 6, 2020
| // CLS requires a different granularity. | ||
| const clsItem = items.find(item => item.metric === 'cumulative-layout-shift'); | ||
| if (clsItem) { | ||
| if (typeof clsItem.measurement !== 'object') { |
Collaborator
Author
There was a problem hiding this comment.
object if is not necessary, but it narrows the type to number|undefined and so is a bit safer, even tho Number(object) would still pass type check
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.