Skip to content

deps(snyk): update script to prune <0.0.0 and update snapshot #11223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
patrickhulce merged 2 commits into from
Aug 6, 2020
Merged

deps(snyk): update script to prune <0.0.0 and update snapshot #11223

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b09fd6
deps(snyk): update script to prune <0.0.0
patrickhulce Aug 5, 2020
dff9c6b
Update lighthouse-core/scripts/cleanup-vuln-snapshot.js
patrickhulce Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions lighthouse-core/scripts/cleanup-vuln-snapshot.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,16 +51,25 @@ function cleanAndFormat(vulnString) {
}
}

for (const libEntries of Object.values(snapshot.npm)) {
for (const [packageName, libEntries] of Object.entries(snapshot.npm)) {
libEntries.forEach((entry, i) => {
// snyk uses a convention for <0.0.0 to represent a mistaken vulnerability in their database.
// https://github.com/GoogleChrome/lighthouse/pull/11144#discussion_r465713835
// From Lighthouse's perspective we don't need to care about these.
Comment thread
patrickhulce marked this conversation as resolved.
const vulnerableVersions = entry.semver.vulnerable.filter(vuln => vuln !== '<0.0.0');

const pruned = {
id: entry.id,
severity: entry.severity,
semver: {vulnerable: entry.semver.vulnerable},
semver: {vulnerable: vulnerableVersions},
};

libEntries[i] = pruned;
});

const filteredEntries = libEntries.filter(entry => entry.semver.vulnerable.length);
snapshot.npm[packageName] = filteredEntries;
if (!filteredEntries.length) delete snapshot.npm[packageName];
}

// Normal pretty JSON-stringify has too many newlines. This strikes the right signal:noise ratio
Expand Down
6 changes: 2 additions & 4 deletions third-party/snyk/snapshot.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,10 +47,8 @@
{"id":"SNYK-JS-DOJO-174933","severity":"medium","semver":{"vulnerable":["<1.2.0"]}},
{"id":"SNYK-JS-DOJO-72305","severity":"medium","semver":{"vulnerable":["<1.14"]}},
{"id":"npm:dojo:20180818","severity":"medium","semver":{"vulnerable":["<1.10.10",">=1.11.0 <1.11.6",">=1.12.0 <1.12.4",">=1.13.0 <1.13.1"]}},
{"id":"npm:dojo:20160523","severity":"medium","semver":{"vulnerable":["<1.1.0"]}},

@paulirish paulirish Aug 5, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was went to <0.0.0 so it was removed.

{"id":"npm:dojo:20100614-6","severity":"medium","semver":{"vulnerable":["<1.4.2"]}},
{"id":"npm:dojo:20100614","severity":"medium","semver":{"vulnerable":[">=0.4.0 <0.4.4",">=1.0.0 <1.0.3",">=1.1.0 <1.1.2",">=1.2.0 <1.2.4",">=1.3.0 <1.3.3",">=1.4.0 <1.4.2"]}},

@paulirish paulirish Aug 5, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one is the same just dropped its comma.

{"id":"npm:dojo:20090409","severity":"medium","semver":{"vulnerable":["<1.1"]}}

@paulirish paulirish Aug 5, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this one (npm:dojo:20090409) also went to <0.0.0 so it was removed.

{"id":"npm:dojo:20100614","severity":"medium","semver":{"vulnerable":[">=0.4.0 <0.4.4",">=1.0.0 <1.0.3",">=1.1.0 <1.1.2",">=1.2.0 <1.2.4",">=1.3.0 <1.3.3",">=1.4.0 <1.4.2"]}}
],
"foundation-sites":[
{"id":"npm:foundation-sites:20170802","severity":"medium","semver":{"vulnerable":["<6.0.0"]}},
Expand Down Expand Up @@ -101,7 +99,7 @@
{"id":"npm:knockout:20130701","severity":"medium","semver":{"vulnerable":[">=2.1.0-pre <3.0.0"]}}
],
"lodash":[
{"id":"SNYK-JS-LODASH-567746","severity":"medium","semver":{"vulnerable":["<=4.17.15"]}},

@paulirish paulirish Aug 5, 2020

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this was a deliberate change discussed in the roll: https://github.com/GoogleChrome/lighthouse/pull/11144/files#r459028283

{"id":"SNYK-JS-LODASH-567746","severity":"medium","semver":{"vulnerable":["<4.17.16"]}},
{"id":"SNYK-JS-LODASH-450202","severity":"high","semver":{"vulnerable":["<4.17.12"]}},
{"id":"SNYK-JS-LODASH-73639","severity":"medium","semver":{"vulnerable":["<4.17.11"]}},
{"id":"SNYK-JS-LODASH-73638","severity":"high","semver":{"vulnerable":["<4.17.11"]}},
Expand Down