core(offscreen-images): loosen to 3 viewports#10643
Merged
devtools-bot merged 3 commits intomasterfrom May 7, 2020
Merged
Conversation
Contributor
Yeah, the heuristic is vague, and this interpretation makes sense to me. Maybe there's an argument for sites that can only scroll left/right, but those are rare enough that we can probably wait for feedback before considering it (it's only an opportunity so we're not hurting their score, after all). |
Collaborator
Author
|
pwa.rocks having interstitial problems apparently. I can't repro locally though 🤔 |
Member
|
The web standards discussion on this issue: whatwg/html#5408 |
paulirish
approved these changes
May 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
We decided to loosen to 3 viewports for offscreen image audit. This only made sense to me for images below the fold so kept our existing restrictions for above and left/right. Let me know if you disagree.
Related Issues/PRs
closes #6677
closes #10471