core: unused-javascript-summary computed artifact by connorjclark · Pull Request #10387 · GoogleChrome/lighthouse

connorjclark · 2020-02-27T00:45:58Z

Needed for #10312 - UnusedJavascript audit and bundle visualization data audit will both need the data from this computed artifact.

Mostly involved moving most of unused-javascript to a computed artifact. No filtering or "transfer size"ing is done in the computed artifact.

commit ecb6260 Author: Connor Clark <cjamcl@google.com> Date: Wed Dec 11 15:17:52 2019 -0800 no index commit 52796db Author: Connor Clark <cjamcl@google.com> Date: Wed Dec 11 15:17:02 2019 -0800 no unshift commit 943e19c Author: Connor Clark <cjamcl@google.com> Date: Wed Dec 11 15:14:21 2019 -0800 deletionBraceCount commit caa269b Author: Connor Clark <cjamcl@google.com> Date: Wed Dec 11 15:13:25 2019 -0800 comments commit e6fde71 Author: Connor Clark <cjamcl@google.com> Date: Wed Dec 11 15:02:50 2019 -0800 semver commit 6480198 Author: Connor Clark <cjamcl@google.com> Date: Tue Dec 10 21:18:36 2019 -0800 update frontend commit 5d17268 Author: Connor Clark <cjamcl@google.com> Date: Tue Dec 10 21:07:44 2019 -0800 rm some ts ignores commit 7129ef9 Author: Connor Clark <cjamcl@google.com> Date: Tue Dec 10 21:04:09 2019 -0800 trim unneeded code commit 0b655b6 Author: Connor Clark <cjamcl@google.com> Date: Tue Dec 10 20:46:11 2019 -0800 better cdt lib gen commit 3333c4f Author: Connor Clark <cjamcl@google.com> Date: Tue Dec 10 20:19:20 2019 -0800 add sections to source map type commit 73eca7b Author: Connor Clark <cjamcl@google.com> Date: Tue Dec 10 20:00:02 2019 -0800 move SDK up b/c global pollution is gone commit 47e8a41 Author: Connor Clark <cjamcl@google.com> Date: Tue Dec 10 19:44:59 2019 -0800 comment commit 9f47880 Author: Connor Clark <cjamcl@google.com> Date: Mon Dec 9 15:02:57 2019 -0800 remove unused js commit 7d50227 Author: Connor Clark <cjamcl@google.com> Date: Sat Dec 7 00:36:07 2019 -0800 nul commit ed4bb21 Author: Connor Clark <cjamcl@google.com> Date: Sat Dec 7 00:33:39 2019 -0800 remove ParsedURL commit 43da869 Author: Connor Clark <cjamcl@google.com> Date: Sat Dec 7 00:30:08 2019 -0800 tmp commit 0d73a8b Author: Connor Clark <cjamcl@google.com> Date: Sat Dec 7 00:22:10 2019 -0800 reduce code commit 4a9127d Author: Connor Clark <cjamcl@google.com> Date: Fri Dec 6 23:52:44 2019 -0800 delete some stuff not needed commit dff8358 Author: Connor Clark <cjamcl@google.com> Date: Fri Dec 6 23:24:48 2019 -0800 errors commit 808736d Author: Connor Clark <cjamcl@google.com> Date: Fri Dec 6 22:56:20 2019 -0800 Common.console commit 122f2a2 Author: Connor Clark <cjamcl@google.com> Date: Fri Dec 6 22:54:42 2019 -0800 ts commit 2f80d5a Author: Connor Clark <cjamcl@google.com> Date: Fri Dec 6 22:50:18 2019 -0800 remove hacky globalThis.cdt commit 7ad9389 Author: Connor Clark <cjamcl@google.com> Date: Fri Dec 6 21:24:00 2019 -0800 do not pollute global array commit fa07a80 Author: Connor Clark <cjamcl@google.com> Date: Fri Dec 6 21:17:56 2019 -0800 mapping test commit f9408f3 Author: Connor Clark <cjamcl@google.com> Date: Fri Dec 6 20:49:23 2019 -0800 count lines commit 6d27caa Author: Connor Clark <cjamcl@google.com> Date: Fri Dec 6 20:41:09 2019 -0800 initial

connorjclark · 2020-04-17T00:21:57Z

I'm working out why results have changed slightly for unused js audit in the smoke test.

silly reason. I forgot to multiply them by the transferRatio. results are the same now.

patrickhulce

I skimmed the bulk of the lines changed and they seemed like a move, but if there are areas to focus more attention on let me know :)

patrickhulce · 2020-04-20T19:28:39Z

+        // Default threshold is 512, but is lowered here so that squoosh generates more
+        // results.
+        // TODO(cjamcl): the bundle visualization feature will require most of the logic currently
+        // done in unused-javascript to be moved to a computed artifact. When that happens, these


isn't that what this is?

I'm a little unclear of what else needs to happen to remove this TODO if it's not this PR :)

so moving this test to the computed artifact makes that file way more complicated. WDYT of keeping the test here, and only testing the source map features of the computed artifact indirectly via the audit test?

yeah keeping the test here sounds fine to me, we've got the basics in place for testing the computed anyhow.

just remove the TODO then :)

Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>

patrickhulce

LGTM! 🎉

patrickhulce · 2020-04-25T00:15:45Z

   * @return {Promise<ByteEfficiencyAudit.ByteEfficiencyProduct>}
   */
  static async audit_(artifacts, networkRecords, context) {
-    const bundles = artifacts.SourceMaps ? await JSBundles.request(artifacts, context) : [];


oof, yeah not sure how I missed this. I guess I was still in "oh just code movement" mode until the additions below 🤦

connorjclark and others added 30 commits December 9, 2019 15:17

initial

4a62a54

do not need _ yet

7886f5e

test for unused bundle

65cc13c

lint

2ed3b7b

fix null mapping bug

652059e

fix counting

b48a400

fix smoke test

7bdf8b4

comment

b6a4a08

comment

b840b10

lint

c3fd09e

better bundle size filter

36c7bee

todo

912f9f1

update bundle.js

ea03907

count new lines

a862683

dont double count

4ff3804

fix test

fa429e0

fix test

74b642d

destructure

1c9d984

lastColumnOfMapping

0d440b2

Merge remote-tracking branch 'origin/master' into unused-js-bundles

60ac62f

Merge remote-tracking branch 'origin/master' into unused-js-bundles

c27aa4a

Merge remote-tracking branch 'origin/master' into unused-js-bundles

e2d1035

fix

e317115

fix one test

d68a555

fix default config test

3d9c5f4

fix

1bd219d

update

4b8fe87

Merge remote-tracking branch 'origin/master' into unused-js-bundles

39a4938

rm old code

d338faf

vercel Bot deployed to Preview April 17, 2020 00:21 View deployment

connorjclark added waiting4reviewer and removed waiting4committer labels Apr 17, 2020

rounding

a83cb4c

vercel Bot deployed to Preview April 17, 2020 00:25 View deployment

patrickhulce reviewed Apr 20, 2020

View reviewed changes

patrickhulce removed the chillin ❄ label Apr 20, 2020

update test

4d5bdae

vercel Bot deployed to Preview April 21, 2020 00:40 View deployment

fix threshold check

3fefa2c

vercel Bot deployed to Preview April 21, 2020 00:51 View deployment

fix threshold again

62e1174

vercel Bot deployed to Preview April 21, 2020 00:56 View deployment

patrickhulce added waiting4committer and removed waiting4reviewer labels Apr 21, 2020

Apply suggestions from code review

b1248b8

Co-Authored-By: Patrick Hulce <patrick.hulce@gmail.com>

vercel Bot deployed to Preview April 21, 2020 20:27 View deployment

connorjclark added 2 commits April 21, 2020 14:18

sort

1579ab0

Merge remote-tracking branch 'origin/master' into unused-js-computed

ca83b85

vercel Bot deployed to Preview April 21, 2020 21:18 View deployment

connorjclark added waiting4reviewer and removed waiting4committer labels Apr 22, 2020

patrickhulce approved these changes Apr 23, 2020

View reviewed changes

patrickhulce added waiting4committer and removed waiting4reviewer labels Apr 23, 2020

connorjclark merged commit 8bd65af into master Apr 23, 2020

connorjclark deleted the unused-js-computed branch April 23, 2020 21:58

connorjclark mentioned this pull request Apr 24, 2020

core(unused-javascript): check for SourceMaps before trying to use #10634

Merged

patrickhulce reviewed Apr 25, 2020

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

core: unused-javascript-summary computed artifact#10387

core: unused-javascript-summary computed artifact#10387
connorjclark merged 63 commits into
masterfrom
unused-js-computed

connorjclark commented Feb 27, 2020 •

edited

Loading

Uh oh!

connorjclark commented Apr 17, 2020

Uh oh!

patrickhulce left a comment

Uh oh!

Uh oh!

Uh oh!

patrickhulce Apr 20, 2020

Uh oh!

connorjclark Apr 21, 2020

Uh oh!

connorjclark Apr 21, 2020

Uh oh!

patrickhulce Apr 21, 2020

Uh oh!

patrickhulce Apr 21, 2020

Uh oh!

Uh oh!

Uh oh!

patrickhulce left a comment

Uh oh!

patrickhulce Apr 25, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

connorjclark commented Feb 27, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

connorjclark commented Apr 17, 2020

Uh oh!

patrickhulce left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

patrickhulce Apr 20, 2020

Choose a reason for hiding this comment

Uh oh!

connorjclark Apr 21, 2020

Choose a reason for hiding this comment

Uh oh!

connorjclark Apr 21, 2020

Choose a reason for hiding this comment

Uh oh!

patrickhulce Apr 21, 2020

Choose a reason for hiding this comment

Uh oh!

patrickhulce Apr 21, 2020

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

patrickhulce left a comment

Choose a reason for hiding this comment

Uh oh!

patrickhulce Apr 25, 2020

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

connorjclark commented Feb 27, 2020 •

edited

Loading