tests(audits): Return type correction (LH.Audit.Result -> LH.Audit.Product)#10270
Merged
paulirish merged 1 commit intoJan 28, 2020
Conversation
paulirish
approved these changes
Jan 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Change #10072 used the
Audit.generateErrorAuditResultfunction to generate a return value, but this return value is of typeLH.Audit.Result, when the caller is expectingLH.Audit.Product.Since the returned value we expect is a relatively simple type, here we construct the relevant fields (
score,errorMessage) directly instead.Related Issues/PRs
#10072