Skip to content

Refactor _renderLink #9631

@connorjclark

Description

@connorjclark

@brendankenny https://github.com/GoogleChrome/lighthouse/pull/9354/files/d2c6b60d45bd5a2bbbcd4ea1361018fd3c9cb263#r319731512

this is getting a little convoluted and makes any changes needed in _renderLink harder to reason about because it now controls renderTextURL and renderSourceLocation. We probably just need to add a "make a link" function in the near future rather than assuming the link details type will always result in the same structure, styling, etc

Metadata

Metadata

Assignees

No one assigned

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions