Skip to content

HTML Report renderer incorrect labels for custom throttling & device #7053

@benschwarz

Description

@benschwarz

Provide the steps to reproduce

  1. Configure lighthouse to run with custom throttling settings, mark the throttling method as devtools, mark the emulatedFormFactor as "none"
  2. Run LH on [any url]
  3. Load the report JSON into lighthouse-viewer

What is the current behaviour?

  • The network throttling summary is hardcoded to "Throttled Slow 4G network"
  • The device summary is hardcoded to "No emulation"
  • The device summary, is technically correct (emulated form factor set to none), but the other configuration options for emulatedFormFactor (mobile, desktop) will result in a hardcoded value of either "Emulated Nexus 5X" or "Emulated Desktop"

What is the expected behaviour?

  • Network throttling summary should describe the network settings used
  • Device summary should describe the device used

Environment Information

  • Affected Channels: Node
  • Lighthouse version: 4.0.0
  • Node.js version: 11
  • Operating System: All

Reference: renderer/util.js#getEmulationDescriptions (Link)

Metadata

Metadata

Assignees

Labels

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions