The double dollar assertion:
|
// '$$' i.e. "Double Dollar" is always invalid in ctc. |
Is a bit aggressive, it should check for basic $$ but allow $ICU_0$$ICU_1$. This should be validated with regex like \$([^$]*?)\$ and asserting that each capture group isn't empty instead of a more basic \$\$.
The double dollar assertion:
lighthouse/lighthouse-core/scripts/i18n/collect-strings.js
Line 344 in e87a8b7
Is a bit aggressive, it should check for basic
$$but allow$ICU_0$$ICU_1$. This should be validated with regex like\$([^$]*?)\$and asserting that each capture group isn't empty instead of a more basic\$\$.