Skip to content
This repository was archived by the owner on Mar 14, 2024. It is now read-only.

Added ngx-lite-video to third-party-facades#6684

Merged
malchata merged 1 commit intoGoogleChrome:mainfrom
karim-mamdouh:ngx-lite-video
Jun 29, 2023
Merged

Added ngx-lite-video to third-party-facades#6684
malchata merged 1 commit intoGoogleChrome:mainfrom
karim-mamdouh:ngx-lite-video

Conversation

@karim-mamdouh
Copy link
Copy Markdown
Contributor

Fixes #6683

Changes proposed in this pull request:

  • Added ngx-lite-video facade to recommended third-party-facaded for youtube & vimeo
  • Name of signed CLA: Karim Mamdouh

@chrome-devrel-infra
Copy link
Copy Markdown

chrome-devrel-infra bot commented Jun 26, 2023

✅ Preview (static) for commit aa7e4a3 available at https://pr-6684-static-dot-dcc-staging.uc.r.appspot.com/.

The following pages likely changed with this PR:

@rachelandrew rachelandrew requested a review from malchata June 26, 2023 11:04
@karim-mamdouh
Copy link
Copy Markdown
Contributor Author

@malchata @rachelandrew
Hi all,
I noticed that there is one workflow pending, is there someone I should request approval from or something pending from my side?? 😅

@malchata
Copy link
Copy Markdown
Member

Currently re-running the workflow, @karim-mamdouh. I can merge once the workflow runs successfully.

@malchata malchata merged commit acd5d11 into GoogleChrome:main Jun 29, 2023
@karim-mamdouh karim-mamdouh deleted the ngx-lite-video branch June 29, 2023 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

content: Adding ngx-lite-video to third-party-facades

2 participants