make launcher.kill() synchronous, fs.rm now gets force and maxRetries#268
Merged
make launcher.kill() synchronous, fs.rm now gets force and maxRetries#268
force and maxRetries#268Conversation
src/chrome-launcher.ts
Outdated
| // backwards support for node v12 + v14.14+ | ||
| // https://nodejs.org/api/deprecations.html#DEP0147 | ||
| const rmSync = this.fs.rmSync || this.fs.rmdirSync; | ||
| rmSync(this.userDataDir, {recursive: true, force: true}); |
Collaborator
There was a problem hiding this comment.
why set force: true now?
Member
Author
There was a problem hiding this comment.
if this dir doesn't exist, we want this fn call to not throw.
connorjclark
approved these changes
May 31, 2022
| // backwards support for node v12 + v14.14+ | ||
| // https://nodejs.org/api/deprecations.html#DEP0147 | ||
| const rmSync = this.fs.rmSync || this.fs.rmdirSync; | ||
| rmSync(this.userDataDir, {recursive: true, force: true, maxRetries: 10}); |
Collaborator
There was a problem hiding this comment.
can you also capture the force / max retry change in the commit title
force and maxRetries
Contributor
|
@paulirish would it make sense to remove the |
Member
Author
|
@calebeby yup sg! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
per #266 there's no reason for this to be async. keeping it async adds extra challenges to both debugging and understanding the flow.
also, added a function test for userdatadir removal
for review, turn off whitespace