Remove CustomSongColorsPatch (fixes #36)#37
Merged
Goobwabber merged 2 commits intoGoobwabber:mainfrom Mar 5, 2023
Merged
Conversation
Contributor
|
Shouldn't the SongCore dependency version be updated to ensure the colors patch is present on that side? |
Collaborator
Author
Good point, I've added that manifest change. SongCore 3.10.1 is in the BeatMods approval queue for 1.28.0, so that version makes sense to target with a next MpCore release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR removes the
CustomSongColorsPatchwith no other changes.The patch itself is not working on the latest SongCore build, because of changes to their config (which causes issue #36 and effectively breaks multiplayer).
SongCore now handles custom song colors itself, so this patch is no longer needed here:
Kylemc1413/SongCore#48