Skip to content

WIP: Support XML DTD#10

Open
isimluk wants to merge 2 commits intoGoComply:masterfrom
isimluk:maintenance
Open

WIP: Support XML DTD#10
isimluk wants to merge 2 commits intoGoComply:masterfrom
isimluk:maintenance

Conversation

@isimluk
Copy link
Member

@isimluk isimluk commented Nov 8, 2022

In order to support the latest usnistgov/metaschema, we need to support XML DTD.

usnistgov/metaschema started including XML DTD tags, we need to support these.

@isimluk isimluk force-pushed the maintenance branch 3 times, most recently from 8cd2a2d to 2f4cdc6 Compare November 8, 2022 21:18
@aj-stein-nist aj-stein-nist mentioned this pull request Feb 22, 2023
Closed
7 tasks
@twa16 twa16 mentioned this pull request May 8, 2023
Open
@isimluk isimluk force-pushed the maintenance branch 2 times, most recently from 9b36887 to 4beb1e8 Compare May 9, 2023 19:57
@xee5ch
Copy link

xee5ch commented Sep 20, 2023

It seems to support the latest Metaschema, re the linked issue in usnistgov/OSCAL#1665, support for XML DTDs is no longer required for the OSCAL Metaschema models, should we close this @isimluk?

@isimluk
Copy link
Member Author

isimluk commented Sep 20, 2023

That's a great news @xee5ch. Thank You!

@isimluk isimluk closed this Sep 20, 2023
@isimluk
Copy link
Member Author

isimluk commented Mar 12, 2024

FYI: I just found that OSCAL is still depending on DTD in the oscal_control-common_metaschema.xml

https://github.com/usnistgov/OSCAL/blob/4f02dac6f698efda387cc5f55bc99581eaf494b6/src/metaschema/oscal_control-common_metaschema.xml#L2-L8

@isimluk isimluk reopened this Mar 12, 2024
@mdk-arc
Copy link

mdk-arc commented Apr 20, 2024 •
edited
Loading

looks like they are exporting things as "_RESOLVED" to get around this, Using this zip https://github.com/usnistgov/OSCAL/releases/download/v1.1.2/oscal-1.1.2.zip and the "metaschema" folder i was able to get to here:

 Processing  oscal_assessment-common_metaschema_RESOLVED.xml
  Processing imported href: oscal_control-common_metaschema_RESOLVED.xml
  Processing imported href: oscal_metadata_metaschema_RESOLVED.xml
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x50 pc=0x523e41]

goroutine 1 [running]:
github.com/gocomply/metaschema/metaschema/parser.(*Metaschema).linkDefinitions(0xc0002d1600)
	/home/arclight/prj/metaschema/metaschema/parser/metaschema_compile.go:75 +0xc1

isimluk added 2 commits July 7, 2025 22:08
@isimluk
Re-enable the test
5d5311f 
This test needs to pass when gocomply/metaschema supports XML DTD.
@isimluk
Work in progress: implement DTD in metaschema parser
0174d0a 
Note DTD implementation in golang xml parser is not straight forward yet
doable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@isimluk @xee5ch @mdk-arc