Change kir /ky/ plural settings to same as for English#1634
Merged
Conversation
Contributor
Author
|
Are there any possible weird side-effects in various places when the plural parameters suddenly change? |
Member
|
For the number of plurals, is changing from 1 to 2, probably the strings with plurals that are "current" will keep that status, but will now be incomplete. Translators and editors should be notified for this changelog, and if possible, the plural strings for the Locale should be marked as fuzzy. |
ocean90
requested changes
Jun 8, 2023
ocean90
left a comment
Member
There was a problem hiding this comment.
Can you update the test to remove the now obsolete exception for kir in
ocean90
reviewed
Jun 8, 2023
`uz` needs to stay, only `kir` can be removed. Props: @ocean90
ocean90
previously approved these changes
Jun 8, 2023
ocean90
reviewed
Jun 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1633