Highlight leading and trailing spaces, and double/multiple spaces in the middle#1500
Merged
Merged
Conversation
Member
Author
|
@amieiro currently the Translation markup is added to editor |
Member
Author
Member
Author
Member
Author
Member
Author
|
Added unit tests for both the spaces highlight introduced in this PR, and the already existent markup for invisible characters as tabs and line breaks |
Member
|
We agreed on our triage session that this can be merged after a code review. The functionality is fine. |
amieiro
approved these changes
Apr 18, 2023
|
just ... thank you so much !!! |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.




What?
Highlight the leading and trailing spaces both in the preview and editor rows
Also highlight double and multiple spaces in the middle.
This PR also adds a missing unit test for the invisible characters markup added on prepare_original() for line breaks and tabs.
Why?
Allows the translator to see the spaces at the beginning or the end of an original/translation.
Allows authors and translators to see double and multiple spaces in the middle of strings.
How?
Wrap the spaces in a
<span>withinvisible-spacesclass, which adds a grey color.Testing Instructions
Fixes #863.