Locales: Correct de_AT country_code, add fa_AF country code.#1491
Merged
Conversation
akirk
approved these changes
Oct 5, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
We're using the GP_Locales for various purposes on WordPress.org, and in one of them I noticed some irregularities in some country_codes listed.
de, instead ofatcountry_code.Notably, I've ignored the following locales, which specify a country in the WP locale:
Why?
Although not the intended use-cases, this had resulted in:
de_DEandde_ATbeing localised toderather thandeandat.de_CHis correctly set toch.fa_AFbeing listed as justfaas it doesn't specify the country code.How?
Testing Instructions
Screenshots or screencast